if else issues

Can you describe your "issue" more detailed. Basically your if else looks ok for me. What does not work in your opinion?

Only as a hint, not all control path of your if else checking returns a value.